[Bug 1795398] [NEW] 'Install samba' option missing in sharing tab of Dolphin's folder properties

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Rik Mills (rikmills):

Cosmic, version 4:18.04.3-0ubuntu1
Bionic, version 4:17.12.3-0ubuntu1

Expected behaviour: If samba is not installed, an 'Install Samba' button
should be present to enable automatic installation of Samba via
packagekit.

Actual behaviour: A message just states that samba is not installed.

This is a regression from Bionic onwards.

The reason is that the feature has not been built is due to the cmake
requirement of:

PackageKitQt5 (required version >= 0.9.5)

erroneously resulting in the output that the requirement is not
satisfied by packagekit-qt 1.0.1

https://bugs.kde.org/show_bug.cgi?id=390599

While this is an error in packagekit-qt's cmake logic (I imagine) other
KDE projects just use 'find_package(PackageKitQt5)' without any
versioning, where < 0.9.5 is long depreciated so not an issue (if it
ever was).

** Affects: kdenetwork-filesharing
Importance: Unknown
Status: Unknown

** Affects: kdenetwork-filesharing (Ubuntu)
Importance: Undecided
Status: New

** Affects: kdenetwork-filesharing (Ubuntu Bionic)
Importance: Undecided
Status: New

** Affects: kdenetwork-filesharing (Ubuntu Cosmic)
Importance: Undecided
Status: New

[Rik Mills]

** Description changed:

- Cosmic, version 4:18.04.3-0ubuntu1
- Bionic, version 4:17.12.3-0ubuntu1
+ Cosmic, version 4:18.04.3-0ubuntu1
+ Bionic, version 4:17.12.3-0ubuntu1

Expected behaviour: If samba is not installed, an 'Install Samba' button
should be present to enable automatic installation of Samba via
packagekit.

Actual behaviour: A message just states that samba is not installed.

This is a regression from Bionic onwards.

- The reason is that the feature has not been built is due to the cmake
+ The reason is that the feature has not been built, due to the cmake
requirement of:

PackageKitQt5 (required version >= 0.9.5)

erroneously resulting in the output that the requirement is not
satisfied by packagekit-qt 1.0.1

https://bugs.kde.org/show_bug.cgi?id=390599

While this is an error in packagekit-qt's cmake logic (I imagine) other
KDE projects just use 'find_package(PackageKitQt5)' without any
versioning, where < 0.9.5 is long depreciated so not an issue (if it
ever was).
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1795398

Title:
'Install samba' option missing in sharing tab of Dolphin's folder
properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdenetwork-filesharing/+bug/1795398/+subscriptions

[Rik Mills]

** Changed in: kdenetwork-filesharing (Ubuntu Cosmic)
Status: New => Fix Committed
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1795398

Title:
'Install samba' option missing in sharing tab of Dolphin's folder
properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdenetwork-filesharing/+bug/1795398/+subscriptions

[Launchpad Bug Tracker]

This bug was fixed in the package kdenetwork-filesharing -
4:18.04.3-0ubuntu2

---------------
kdenetwork-filesharing (4:18.04.3-0ubuntu2) cosmic; urgency=medium

* Add patch to fix building with packagekit-qt (v1.0.1). Restores
missing option to install samba from the 'Share' tab in Dolphin's
folder properties dialog. (LP: #1795398)
- debian/patches: kubuntu_fix-cmake-PackageKitQt5-version.patch

-- Rik Mills <***@kubuntu.org> Mon, 01 Oct 2018 15:01:54 +0100

** Changed in: kdenetwork-filesharing (Ubuntu Cosmic)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1795398

Title:
'Install samba' option missing in sharing tab of Dolphin's folder
properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdenetwork-filesharing/+bug/1795398/+subscriptions

[Bug Watch Updater]

Launchpad has imported 5 comments from the remote bug at
https://bugs.kde.org/show_bug.cgi?id=390599.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2018-02-17T09:31:39+00:00 Rik Mills wrote:

With PackageKit 1.0.x, this is not an acceptable version during
configure, so features are disabled and lost.

** log extract **

Could not find a configuration file for package "PackageKitQt5" that is
compatible with requested version "0.9.5".

The following configuration files were considered but not accepted:

/usr/lib/x86_64-linux-
gnu/cmake/packagekitqt5/packagekitqt5-config.cmake, version: 1.0.1

<snip>

-- The following features have been disabled:

* Samba Installation, Automatic installation of '"samba"' using
PackageKit.

-- The following OPTIONAL packages have not been found:

* PackageKitQt5 (required version >= 0.9.5), Software Manager integration
Needed to automatically install the samba package.

Reply at: https://bugs.launchpad.net/ubuntu/+source/kdenetwork-
filesharing/+bug/1795398/comments/0

------------------------------------------------------------------------
On 2018-03-01T02:08:04+00:00 Cfeck wrote:

Would you be able to propose a fix? openSUSE Tumbleweed still uses
PackageKit-Qt 0.9.6, so I cannot investigate locally.

Reply at: https://bugs.launchpad.net/ubuntu/+source/kdenetwork-
filesharing/+bug/1795398/comments/1

------------------------------------------------------------------------
On 2018-10-01T14:28:51+00:00 Rik Mills wrote:

(In reply to Christoph Feck from comment #1)

Would you be able to propose a fix? openSUSE Tumbleweed still uses
PackageKit-Qt 0.9.6, so I cannot investigate locally.

https://phabricator.kde.org/D15874

Reply at: https://bugs.launchpad.net/ubuntu/+source/kdenetwork-
filesharing/+bug/1795398/comments/3

------------------------------------------------------------------------
On 2018-10-04T11:54:59+00:00 Rik Mills wrote:

Git commit 1895a88670e6bef79fa07fe13335373956eedf9c by Rik Mills.
Committed on 04/10/2018 at 11:54.
Pushed by rikmills into branch 'master'.

allow building with packagekit-qt >= 1.0.0

Summary:
Currently fails to recognise packagekit-qt >= 1.0.0 with the message:
Could not find a configuration file for package "PackageKitQt5" that is compatible with requested version "0.9.5"
This results in the 'share' tab of Dolphin's folder properties simply
stating that samba is not installed, with the button which offers to
install this via packagekit not being present.
Currently known to affect at lease Kubuntu 18.04, 18.10, and Neon 18.04
packagekit-qt 0.9.5 dates from 2014, so regardless of more complicated
solutions, the version requirement can be dropped here.

Test Plan:
- Apply patch to Kubuntu CI builds of 18.08 branch.
- Apply patch to eariler releases for potential bugfix in Kubuntu
- Confirm that the button to install samba appears, installs samba,
and that the samba sharing config options for the folder then appear.

Reviewers: cfeck, ngraham

Reviewed By: ngraham

Differential Revision: https://phabricator.kde.org/D15874

M +1 -1 CMakeLists.txt

https://commits.kde.org/kdenetwork-
filesharing/1895a88670e6bef79fa07fe13335373956eedf9c

Reply at: https://bugs.launchpad.net/ubuntu/+source/kdenetwork-
filesharing/+bug/1795398/comments/5

------------------------------------------------------------------------
On 2018-10-04T11:57:03+00:00 Rik Mills wrote:

Git commit 3394a564ec62a40ed99c185324993205f9a72641 by Rik Mills.
Committed on 04/10/2018 at 11:56.
Pushed by rikmills into branch 'Applications/18.08'.

allow building with packagekit-qt >= 1.0.0

Summary:
Currently fails to recognise packagekit-qt >= 1.0.0 with the message:
Could not find a configuration file for package "PackageKitQt5" that is compatible with requested version "0.9.5"
This results in the 'share' tab of Dolphin's folder properties simply
stating that samba is not installed, with the button which offers to
install this via packagekit not being present.
Currently known to affect at lease Kubuntu 18.04, 18.10, and Neon 18.04
packagekit-qt 0.9.5 dates from 2014, so regardless of more complicated
solutions, the version requirement can be dropped here.

Test Plan:
- Apply patch to Kubuntu CI builds of 18.08 branch.
- Apply patch to eariler releases for potential bugfix in Kubuntu
- Confirm that the button to install samba appears, installs samba,
and that the samba sharing config options for the folder then appear.

Reviewers: cfeck, ngraham

Reviewed By: ngraham

Differential Revision: https://phabricator.kde.org/D15874

M +1 -1 CMakeLists.txt

https://commits.kde.org/kdenetwork-
filesharing/3394a564ec62a40ed99c185324993205f9a72641

Reply at: https://bugs.launchpad.net/ubuntu/+source/kdenetwork-
filesharing/+bug/1795398/comments/6


** Changed in: kdenetwork-filesharing
Status: Unknown => Fix Released

** Changed in: kdenetwork-filesharing
Importance: Unknown => Medium
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1795398

Title:
'Install samba' option missing in sharing tab of Dolphin's folder
properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdenetwork-filesharing/+bug/1795398/+subscriptions